Implement Deno benchmark extract#286
Open
Garciat wants to merge 2 commits intobenchmark-action:masterfrom
Open
Implement Deno benchmark extract#286Garciat wants to merge 2 commits intobenchmark-action:masterfrom
Garciat wants to merge 2 commits intobenchmark-action:masterfrom
Conversation
Member
|
hey @Garciat Thank you very much for this contribution! The only problem I see is that the generated benchmark name is very hard to read. Wouldn't using the group and the name combination be enough? The origin field seems to obfuscate the resulting name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #232
Local build branch: https://github.com/Garciat/github-action-benchmark/tree/deno-benchmark-v1
Successful job run: https://github.com/Garciat/wgpu-memory/actions/runs/12535881440/job/34958251449
Final output: https://garciat.com/wgpu-memory/benchmarks/